pmalafosse commented on pull request #17209:
URL: https://github.com/apache/airflow/pull/17209#issuecomment-890378194


   I added some other tests for _last_log_messages and making sure it works if 
there are no messages at all.
   
   I wanted to do all of that in the same test instead of splitting it into 2 
(one for _last_log_messages() and one for the exception message) but 
unfortunately there are issues with mocks and generators (can only be called 
once because then it's empty) and fixing this with 
https://stackoverflow.com/a/65019164/5706548 might be confusing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to