milton0825 edited a comment on issue #5085: [WIP][AIRFLOW-594] Add dag source 
plugin hooks
URL: https://github.com/apache/airflow/pull/5085#issuecomment-485343040
 
 
   @drewsonne 
   I think this PR and AIP-5 should share the same fetcher interface like 
`AirflowPluginDagSource`  with two methods you proposed but I would probably 
rename it to `BaseDagFetcher` . AFAIK the only difference is that you propose 
to load the DAG once during startup (correct me if I am wrong) and AIP-5 
propose to fetch from remote periodically.  
   
   Also I would recommend you to write an AIP about what you are proposing so 
that we all can have a better understanding of your proposal and we can 
consolidate things.
   
   Cheers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to