uranusjr commented on a change in pull request #17319:
URL: https://github.com/apache/airflow/pull/17319#discussion_r680747249



##########
File path: docs/apache-airflow/best-practices.rst
##########
@@ -109,8 +112,12 @@ or if you need to deserialize a json object from the 
variable :
 
     {{ var.json.<variable_name> }}
 
-An alternative option is to use environment variables in the top-level python 
code or use Environment Variables to create and manage Airflow variables. to 
manage Airflow Variables. This will avoid new connections to Airflow metadata 
DB every time Airflow parses the python file. For more information, see: 
:ref:`managing_variables`.
+For security purpose, you're recommended to use the :ref:`Secrets 
Backend<secrets_backend_configuration>`
+for any variable that contains sensitive data.
 
+An alternative option is to use environment variables in the top-level Python 
code or use environment variables to
+create and manage Airflow variables. This will avoid new connections to 
Airflow metadata DB every time
+Airflow parses the Python file. For more information, see: 
:ref:`managing_variables`.

Review comment:
       Yeah that makes sense to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to