uranusjr commented on issue #17374: URL: https://github.com/apache/airflow/issues/17374#issuecomment-890915045
I think it’d work. AppBuilder is initialised here: https://github.com/apache/airflow/blob/71088986f12be3806d48e7abc722c3f338f01301/airflow/www/extensions/init_appbuilder.py#L46-L52 and `settings.Session` is initialised here: https://github.com/apache/airflow/blob/71088986f12be3806d48e7abc722c3f338f01301/airflow/settings.py#L204-L235 So I think we just need to consider `sql_alchemy_schema` in `prepare_engine_args`. Backward compatibility would be the biggest issue though; we need to prevent breaking people using the current setup (not putting F.A.B. models inside a schema). But I think it can be done. Would you be interested in taking a shot at this and submit a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
