This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 9a09b29dd74adea8e1fbf9d2a7c500cb2b852a9e Author: Kanthi <[email protected]> AuthorDate: Fri Jul 30 15:18:26 2021 -0400 Added print statements for clarity in provider yaml checks (#17322) (cherry picked from commit 76e6315473671b87f3d5fe64e4c35a79658789d3) --- .../ci/pre_commit/pre_commit_check_provider_yaml_files.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py index 24d963b..c6c0584 100755 --- a/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py +++ b/scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py @@ -119,13 +119,13 @@ def assert_sets_equal(set1, set2): lines = [] if difference1: - lines.append('Items in the first set but not the second:') + lines.append(' -- Items in the left set but not the right:') for item in sorted(difference1): - lines.append(repr(item)) + lines.append(f' {item!r}') if difference2: - lines.append('Items in the second set but not the first:') + lines.append(' -- Items in the right set but not the left:') for item in sorted(difference2): - lines.append(repr(item)) + lines.append(f' {item!r}') standard_msg = '\n'.join(lines) raise AssertionError(standard_msg) @@ -155,6 +155,7 @@ def parse_module_data(provider_data, resource_type, yaml_file_path): def check_completeness_of_list_of_hooks_sensors_hooks(yaml_files: Dict[str, Dict]): print("Checking completeness of list of {sensors, hooks, operators}") + print(" -- {sensors, hooks, operators} - Expected modules(Left): Current Modules(Right)") for (yaml_file_path, provider_data), resource_type in product( yaml_files.items(), ["sensors", "operators", "hooks"] ): @@ -193,6 +194,8 @@ def check_duplicates_in_integrations_names_of_hooks_sensors_operators(yaml_files def check_completeness_of_list_of_transfers(yaml_files: Dict[str, Dict]): print("Checking completeness of list of transfers") resource_type = 'transfers' + + print(" -- Expected transfers modules(Left): Current transfers Modules(Right)") for yaml_file_path, provider_data in yaml_files.items(): expected_modules, provider_package, resource_data = parse_module_data( provider_data, resource_type, yaml_file_path @@ -309,7 +312,10 @@ def check_doc_files(yaml_files: Dict[str, Dict]): } try: + print(" -- Checking document urls: expected(left), current(right)") assert_sets_equal(set(expected_doc_urls), set(current_doc_urls)) + + print(" -- Checking logo urls: expected(left), current(right)") assert_sets_equal(set(expected_logo_urls), set(current_logo_urls)) except AssertionError as ex: print(ex)
