uranusjr commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-891495665
Implementation LGTM! I’m wondering about the interface though. Right now the default `split_statements` is False, but the argument is persuambly meaningless when `sql` contains only one statement (barring sqlparse bugs), so the only scenario you’d want `split_statements=False` *and* be meaningful is when `sql` contains multiple statements but you don’t want them to be splitted (or when `sqlparse` incorrectly splits a statment into multiple ones), which is quite rare. So I feel maybe `split_statements` should default to True instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
