[GitHub] [airflow] cpdean commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

[GitBox]

cpdean commented on pull request #15599:
URL: https://github.com/apache/airflow/pull/15599#issuecomment-891921076


   I am trying to get my installation of airflow to mask passwords in the 
rendered template UI of a given task. It seems this pull request was merged and 
made available somewhere between versions 2.0.0 and 2.1.0
   
   ```
   1 - ❯❯❯ git log 2.0.0..2.1.0 | rg 15599
       Mask passwords and sensitive info in task logs and UI (#15599)
   commit 6019c78cb475800f58714a9dabb747b9415599c8
   ```
   
   I have airflow 2.1.2, but I still see passwords being rendered and freely 
visible to anyone with access to airflow.  
   
   Is there something I have to do to enable masking passwords rendered in 
templates to the UI? 
   
   I'm using an Admin account locally to test.
   
   Here is the variable I would like to be masked in templates, airflow 
correctly masks it in the variable UI
   
   <img width="694" alt="image" 
src="https://user-images.githubusercontent.com/160099/128038182-a26a8c8e-6f06-49ba-bef9-e6e165f59694.png";>
   
   On the rendered template page of a given task, however, it freely shows the 
password to me:
   
   <img width="529" alt="image" 
src="https://user-images.githubusercontent.com/160099/128038367-94f015ce-af46-4a09-8fb3-d9dc3b74bbaa.png";>
   
   
   I have airflow 2.1.2 installed, ` 
.release:2.1.2+d25854dd413aa68ea70fb1ade7fe01425f456192` per the screenshot 
from the UI footer:
   
   <img width="525" alt="image" 
src="https://user-images.githubusercontent.com/160099/128038496-99560d9b-86e0-4745-ab44-5639611f6a4b.png";>
   
   What am I doing wrong here? How can I allow dockerized tasks to have access 
to the systems they need without broadcasting the credentials to everyone?
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org