potiuk commented on a change in pull request #17423:
URL: https://github.com/apache/airflow/pull/17423#discussion_r683012725
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -70,6 +70,7 @@ def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
self.connection: Optional[Connection] = kwargs.pop("connection", None)
self.conn: connection = None
+ self.schema: Optional[str] = kwargs.pop("schema", None)
Review comment:
Right - I think i fiigured out better way of doing it. I've added the
'schema' argument explicitly as optional kwarg to DBApiHook and made a comment
about the "change schema value" in the description of the parameter.
I think it's much better - it makes schema an explicit part of the DBHookAPI
hook's API, it is fully backwards compatible and it makes it very easy for
Airflow 3 change - we will simply make the self.schema public and convert all
the operators that use it in the "old" way. See the latest fixup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
