potiuk commented on a change in pull request #17426:
URL: https://github.com/apache/airflow/pull/17426#discussion_r683185788
##########
File path: airflow/cli/cli_parser.py
##########
@@ -60,10 +62,15 @@ def _check_value(self, action, value):
if action.dest == 'subcommand' and value == 'celery':
executor = conf.get('core', 'EXECUTOR')
if executor not in (CELERY_EXECUTOR, CELERY_KUBERNETES_EXECUTOR):
- message = (
- f'celery subcommand works only with CeleryExecutor, your
current executor: {executor}'
- )
- raise ArgumentError(action, message)
+ executor_cls =
import_string(ExecutorLoader.executors.get(executor, executor))
+ if not issubclass(
+ executor_cls,
+ (celery_executor.CeleryExecutor,
celery_kubernetes_executor.CeleryKubernetesExecutor),
+ ):
+ message = (
+ f'celery subcommand works only with CeleryExecutor,
your current executor: {executor}'
Review comment:
NIT. but should be more helpful in case of more complex hierarchies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
