ashb commented on a change in pull request #17410:
URL: https://github.com/apache/airflow/pull/17410#discussion_r682526692
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -190,6 +191,15 @@ def _read(self, ti, try_number, metadata=None):
response.raise_for_status()
log += '\n' + response.text
+ except HTTPStatusError as e:
+ if e.response.status_code == 403:
+ log += f"*** Failed to fetch log file from worker With
403, Forbidden error. {str(e)}\n"
Review comment:
```suggestion
log += f"*** Failed to fetch log file from worker With
{str(e)}\n"
```
I'd guess (but haven't tested) that stringifying the error would show "403
Forbidden" -- and if so we don't need to say that again.
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -22,6 +22,7 @@
from typing import TYPE_CHECKING, Optional
import httpx
+from httpx import HTTPStatusError
Review comment:
```suggestion
```
Unused import now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
