potiuk commented on a change in pull request #17426:
URL: https://github.com/apache/airflow/pull/17426#discussion_r684113177
##########
File path: airflow/cli/cli_parser.py
##########
@@ -60,10 +62,17 @@ def _check_value(self, action, value):
if action.dest == 'subcommand' and value == 'celery':
executor = conf.get('core', 'EXECUTOR')
if executor not in (CELERY_EXECUTOR, CELERY_KUBERNETES_EXECUTOR):
- message = (
- f'celery subcommand works only with CeleryExecutor, your
current executor: {executor}'
- )
- raise ArgumentError(action, message)
+ executor_cls =
import_string(ExecutorLoader.executors.get(executor, executor))
Review comment:
@mik-laj is right. And loading executor might not be a good idea here
actually, because there might be some side effects of instantiating the
executor twice. But I think there is an easier way. Simply calling
`ExecutorLoader.get_default_executor()` should return the executor object
properly (as singleton as well - so it won't be initialized twice).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
