subkanthi commented on a change in pull request #17400:
URL: https://github.com/apache/airflow/pull/17400#discussion_r684193248



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -195,49 +196,50 @@ class SlackAPIFileOperator(SlackAPIOperator):
     :type content: str
     """
 
-    template_fields = ('channel', 'initial_comment', 'filename', 'filetype', 
'content')
+    template_fields = ('channel', 'initial_comment', 'filetype', 'content')
     ui_color = '#44BEDF'
 
     def __init__(
         self,
         channel: str = '#general',
         initial_comment: str = 'No message has been set!',
-        filename: str = None,
+        file: str = None,

Review comment:
       please let me know , I can add to CHANGELOG, but as I mentioned before, 
for files, we need to open the file and pass the bufferedreader to Slack API, 
it was not done before




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to