potiuk edited a comment on issue #17489:
URL: https://github.com/apache/airflow/issues/17489#issuecomment-894825583


   Yeah @mik-laj is right. You can also see examples of that explained in our 
documentation - 
https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#handling-of-special-characters-in-connection-params
 according to https://datatracker.ietf.org/doc/html/rfc3986 both pasword and 
user should be percent-encoded. 
   
   However I am a bit surprised to see '+' in your issue rather than %20 (which 
should be used in this case). 
   
   The '+' replacing ' ' is part of another specification 
https://datatracker.ietf.org/doc/html/rfc1866 - there space might be replaced 
by '+' only in the context of form fields or form values - strictly when the 
HTML data is encoded with `application/x-www-form-urlencoded`.  This sounds as 
completely different case and should never be used in URI's (though from what I 
know a lot of URI parsers will happily accept + as 'space' in other places, but 
this is rather a side-effect not specification-conformance.
   
   Could you please @EliMor provide us examples of such secrets generated (with 
some bogus passwords?) was it part of the URI or form? Or some other secret 
content?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to