ephraimbuddy commented on a change in pull request #16475:
URL: https://github.com/apache/airflow/pull/16475#discussion_r685879899
##########
File path: airflow/jobs/backfill_job.py
##########
@@ -471,6 +476,13 @@ def _per_task_process(key, ti, session=None):
ti_status.running.pop(key)
# Reset the failed task in backfill to scheduled state
ti.set_state(State.SCHEDULED, session=session)
+ elif self.rerun_succeeded_tasks and ti.state == State.SUCCESS:
+ # Rerun succeeded tasks
+ self.log.info("Task instance {ti} with state
{state}".format(ti=ti, state=ti.state))
Review comment:
```suggestion
self.log.info("Task instance %s with state %s", ti,
ti.state)
```
For some reasons, we don't use `format` in log messages. We prefer using
`%s`. Also, should we make the log to convey a good message, like, Task
instance with state ... succeeded. rerunning task? what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
