ShakaibKhan commented on a change in pull request #15385:
URL: https://github.com/apache/airflow/pull/15385#discussion_r688718313
##########
File path: tests/www/views/test_views.py
##########
@@ -93,6 +95,28 @@ def test_plugin_endpoint_should_not_be_unauthenticated(app):
check_content_in_response("Sign In - Airflow", resp)
+def test_should_list_providers_on_page_with_details(admin_client):
+ pm = ProvidersManager()
+ resp = admin_client.get('/provider')
+
+ for pi in pm.providers.values():
+ check_content_in_response("<td>" + pi.version + "</td>", resp)
+ check_content_in_response("<td>" + pi[1]["package-name"] + "</td>",
resp)
+ cd = re.sub(
+ ">",
+ "\">[site]</a>",
+ re.sub("<", "<a href=\"", re.sub("[`_]", "",
pi[1]["description"].strip(" \n.").strip("\""))),
+ )
Review comment:
Yeah I agree that I probably shouldnt repeat the logic here. Correct me
if I am wrong but should the test look more like checking for a provider that
we know is provided and check it is rendered on the page (w/ static values)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
