ashb commented on a change in pull request #17618:
URL: https://github.com/apache/airflow/pull/17618#discussion_r688978588
##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -144,6 +144,11 @@ def _record_attrs_to_ignore(self) -> Iterable[str]:
)
return frozenset(record.__dict__).difference({'msg', 'args'})
+ def _redact_exception_with_context(self, exception):
+ exception.args = (self.redact(v) for v in exception.args)
+ if exception.__context__:
Review comment:
Oh there's also a `__cause__` attr that we should probably redact too.
##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -144,6 +144,11 @@ def _record_attrs_to_ignore(self) -> Iterable[str]:
)
return frozenset(record.__dict__).difference({'msg', 'args'})
+ def _redact_exception_with_context(self, exception):
+ exception.args = (self.redact(v) for v in exception.args)
+ if exception.__context__:
Review comment:
Oh there's also a `__cause__` attr that we should probably redact too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
