lwyszomi opened a new pull request #17137: URL: https://github.com/apache/airflow/pull/17137
Related: https://github.com/apache/airflow/issues/13779 Give a possibility to run `wait_for_pipeline_state` with default or provided parameters, remove unnecessary call inside `start_pipeline` hook. Why I removed `wait_for_pipeline_state` from `start_pipeline` hook. By this call, I think we have a bug in this operator, for example when we have pipeline which starting more than `300` seconds, so it have a starting status, we get the error because this pipepline is not in correct state after `300` seconds. Even when we pass our parameters `sucess_states` and `pipeline_timeout` we get this error in this case, so I think when I pass both parameters the logic should use them not default. Why we have `300` second and these `SUCCESS_STATES + [PipelineStates.RUNNING]`, because we had these values in the `wait_for_pipeline_state` call which I removed from hook, I think we should replace this 300 second and use default value from `__init__` method (this is a open question I think) --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
