ashb commented on a change in pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#discussion_r690287118
##########
File path: airflow/models/dagrun.py
##########
@@ -286,7 +287,17 @@ def find(
@staticmethod
def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str:
"""Generate Run ID based on Run Type and Execution Date"""
- return f"{run_type}__{execution_date.isoformat()}"
+ from airflow.configuration import conf
+ local_run_id = conf.getboolean("core", "localize_dag_run_id",
fallback=False)
+ if local_run_id:
+ local_time =
pendulum.instance(execution_date).astimezone(tz=settings.TIMEZONE)
+ is_dst = local_time.is_dst()
+ if is_dst:
+ return f"{run_type}__{local_time.isoformat()}__DST"
Review comment:
I don't see the need for this suffix -- when it's in DST the timezone
offset will already be different (`+00:00` vs `+01:00__DST` in your example for
UK)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
