potiuk commented on a change in pull request #17682:
URL: https://github.com/apache/airflow/pull/17682#discussion_r691178521
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -744,9 +744,22 @@ hook-class-names:
- airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLHook
- airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLDatabaseHook
- airflow.providers.google.cloud.hooks.compute_ssh.ComputeEngineSSHHook
- - airflow.providers.google.cloud.hooks.bigquery.BigQueryHook
Review comment:
This hook here made no sense. It's connection_type was the same as
GoogleBaseHook.
##########
File path: airflow/providers/microsoft/azure/hooks/azure_container_instance.py
##########
@@ -41,6 +41,11 @@ class AzureContainerInstanceHook(AzureBaseHook):
:type azure_conn_id: str
"""
+ conn_name_attr = 'azure_conn_id'
Review comment:
This connection type was duplicated with AzureBaseHook
##########
File path: BREEZE.rst
##########
@@ -15,12 +15,12 @@
specific language governing permissions and limitations
under the License.
-.. raw:: html
+`.. raw:: html
<div align="center">
<img src="images/AirflowBreeze_logo.png"
alt="Airflow Breeze - Development and Test Environment for Apache
Airflow">
- </div>
+ </div>`
Review comment:
Not really :)
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -744,9 +744,22 @@ hook-class-names:
- airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLHook
- airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLDatabaseHook
- airflow.providers.google.cloud.hooks.compute_ssh.ComputeEngineSSHHook
- - airflow.providers.google.cloud.hooks.bigquery.BigQueryHook
Review comment:
I actually brought it back with different connection type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
