kaxil commented on a change in pull request #17674:
URL: https://github.com/apache/airflow/pull/17674#discussion_r691067036
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image)
Review comment:
Nope, then make it 3 :)
We already have another section for oushing after Vote too
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :) -
so definitely not a good reason ;)
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image)
Review comment:
Check under RC section and then check under Publish final version :)
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -40,7 +39,7 @@
- [Publish release to SVN](#publish-release-to-svn)
- [Prepare PyPI "release" packages](#prepare-pypi-release-packages)
- [Update CHANGELOG.md](#update-changelogmd)
- - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image-1)
+ - [Manually prepare production Docker
Image](#manually-prepare-production-docker-image)
Review comment:
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#prepare-production-docker-image
https://github.com/astronomer/airflow/blob/067738926c75148b21a41d94b48fcb5c57b9d0db/dev/README_RELEASE_AIRFLOW.md#manually-prepare-production-docker-image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
