LionelZhao28 edited a comment on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-900929938
Commit the new changes.
There are two new changes:
1. remove `__DST` suffix in the `run_id` as the offset will change when
changing the DST,
2. After discussing @ashb , use dag `timezone` instead of `default_timezone`
make sense, we have three ways to do this:
1. We use the `execution_date` timezone directly. But I found the
`execution_date` is UTC already, and if we transform it before calling the
method `DagRun.generate_run_id`, the changes will have a big risk because it
may affect the task scheduler. So give it up
2. change the method `DagRun.generate_run_id` from staticmethod to
classmethod, and it leads that there must be a dag model before calling the
method. So give it up
3. add a parameter `dag_timezone` in the method `generate_run_id`. I
scan the usage of this method in the project and we can get the dag_time in all
the calling codes, and there are not too many actually. So I follow this way.
Actually, I'm still not sure about the second change, we can continue the
discussion about it here .
Thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
