potiuk commented on a change in pull request #17682:
URL: https://github.com/apache/airflow/pull/17682#discussion_r691694600
##########
File path: airflow/providers/apache/druid/provider.yaml
##########
@@ -51,6 +51,10 @@ hooks:
hook-class-names:
- airflow.providers.apache.druid.hooks.druid.DruidDbApiHook
+connection-types:
Review comment:
We will be able to do it when we add dependency on Airflow 2.2 but this
will happen only after some time when we will have good reason for it. And even
then the code to parse it we will be able to remove only in Airflow 3 really.
I treat it also partially as exercise to learn and solve potential
deprecation/feature patterns we might have for providers vs. Airflow. This is a
rather straightforward change but we might learn how to deal with evolving
providers smoothly.
We do not "have to" do it now (it's not a huge optimisation), but I figured
this might be good idea to implement it and see what it brings. I think that
this is a good outcome from that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
