kaxil commented on a change in pull request #17700:
URL: https://github.com/apache/airflow/pull/17700#discussion_r691719277
##########
File path: airflow/providers/google/cloud/operators/kubernetes_engine.py
##########
@@ -292,6 +292,12 @@ def __init__(
"Credentials (ADC) strategy for authorization, create an empty
connection "
"called `google_cloud_default`.",
)
+ # There is no need to manage the kube_config file, as it will be
generated automatically.
+ # All Kubernetes parameters (except config_file) are also valid for
the GKEStartPodOperator.
+ if self.config_file:
+ raise AirflowException(
+ "config_file is not an allowed parameter for the
GKEStartPodOperator."
+ )
Review comment:
```suggestion
raise AirflowException("config_file is not an allowed parameter
for the GKEStartPodOperator.")
```
##########
File path: airflow/providers/google/cloud/operators/kubernetes_engine.py
##########
@@ -303,6 +309,7 @@ def execute(self, context) -> Optional[str]:
"keyword project_id parameter or as project_id extra "
"in Google Cloud connection definition. Both are not set!"
)
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]