[
https://issues.apache.org/jira/browse/AIRFLOW-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824766#comment-16824766
]
ASF GitHub Bot commented on AIRFLOW-4399:
-----------------------------------------
XD-DENG commented on pull request #5165: [AIRFLOW-4399] Avoid duplicated
os.path.isfile() check in models.dagbag
URL: https://github.com/apache/airflow/pull/5165
### Jira
- https://issues.apache.org/jira/browse/AIRFLOW-4399
### Description
The check which is removed in this commit always returns `True` for sure,
because the same check has already been done earlier in this function body
https://github.com/apache/airflow/blob/de1795c8f1e65a5f4a848e88ef3848ba51aab449/airflow/models/dagbag.py#L157-L158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> To avoid duplicated os.path.isfile(filepath) checks in models.dagbag
> --------------------------------------------------------------------
>
> Key: AIRFLOW-4399
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4399
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Affects Versions: 1.10.3
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
> Fix For: 1.10.4
>
>
> There are duplicated os.path.isfile(filepath) checks, among which the 2nd one
> is not necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
