kaxil commented on a change in pull request #17683: URL: https://github.com/apache/airflow/pull/17683#discussion_r692229613
########## File path: UPDATING.md ########## @@ -89,6 +89,11 @@ installing Airflow, example for Python 3.8 and Airflow 2.1.2: pip install -U "apache-airflow[pandas]==2.1.2" \ --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.1.2/constraints-3.8.txt"; ``` +### `none_failed_or_skipped` trigger rule has been deprecated Review comment: ```suggestion ### `none_failed_or_skipped` trigger rule has been deprecated ``` ########## File path: UPDATING.md ########## @@ -89,6 +89,11 @@ installing Airflow, example for Python 3.8 and Airflow 2.1.2: pip install -U "apache-airflow[pandas]==2.1.2" \ --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.1.2/constraints-3.8.txt"; ``` +### `none_failed_or_skipped` trigger rule has been deprecated Review comment: Should fix failing static check- https://github.com/apache/airflow/pull/17683/checks?check_run_id=3372171479#step:10:242 ########## File path: tests/utils/test_trigger_rule.py ########## @@ -33,4 +33,5 @@ def test_valid_trigger_rules(self): assert TriggerRule.is_valid(TriggerRule.NONE_SKIPPED) assert TriggerRule.is_valid(TriggerRule.DUMMY) assert TriggerRule.is_valid(TriggerRule.ALWAYS) + assert TriggerRule.is_valid(TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS) assert len(TriggerRule.all_triggers()) == 10 Review comment: ```suggestion assert TriggerRule.is_valid(TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS) assert len(TriggerRule.all_triggers()) == 11 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
