er1shivam opened a new pull request #30: URL: https://github.com/apache/airflow-client-python/pull/30
Fix for [Issue 27:](https://github.com/apache/airflow-client-python/issues/27) The `dag_run_timeout` in `dag_details` need to accept None type as its parameter type, because `dag_run_timeout` is an optional parameter on [DAG API](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/dag/index.html#airflow.models.dag.DAG). So , most of the times this parameter will be None whenever no one is specifically mentioning it in their dags. And It is also clearly mentioned in the definition [here](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/dag/index.html#airflow.models.dag.DAG). Small extract.. `....max_active_runs: int = conf.getint('core', 'max_active_runs_per_dag'), dagrun_timeout: Optional[timedelta] = None,sla_miss_callback: Optional[Callable] = None,..` So , we need to update this params to accept None type as well. Tested it on multiple dags after updating this and it worked fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
