potiuk commented on pull request #17729: URL: https://github.com/apache/airflow/pull/17729#issuecomment-903096436
> In this case, would `ascii_general_ci` be even better? Maybe in the future we will allow non-ascii for IDs? Who knows. Utf8_mb3 is fully ascii-compatible, so I think we are ok with that. > If not, I feel we should just _default_ to `utf8mb3_general_ci` but still allow users to override it to something else. If the user uses `utf8mb4_general_ci`, that’s on them; we can document this or even explicitly prevent this user error by raising an exception. This is how it works actually :). Effectively for MySQL (and now also mariadb) the default will be `utf8mb3_general_ci` but if you set collation parameter, it will be used instead. This whole (`if mysql`) only happens if collation is not set (see few lines above) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
