suhanovv commented on pull request #17769:
URL: https://github.com/apache/airflow/pull/17769#issuecomment-903592983


   > Is there a reason we don't emit the metric when each file is finished 
parsing instead? Tying metrics emission to how often we _print_ them in the 
logs seems slightly unexpected.
   
   I think that sending the metric `dag_processing.last_duration.{file_name}` 
right after the file has finished processing is much better and more obvious. 
And I would still leave the metric 
`dag_processing.last_run.seconds_ago.{file_name}` in the binding to _print_stat.
   
   if there is no reason why should not transfer the metric, then I will 
transfer the emission of the `dag_processing.last_duration.{file_name}` to the 
DagFileProcessorManager._collect_results_from_processor method, okay?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to