potiuk commented on issue #5019: [AIRFLOW-4199][AIP-3-step3] Remove all sys version info URL: https://github.com/apache/airflow/pull/5019#issuecomment-486087993 Maybe I am missing something but here is my understanding (from looking at the logs at least): Those files in _vendor dir have been modified already in the past - they were modified so that we do not have to pull-in the GPL dependency - we cannot have it from pypi so we brought it in with original version: e36bdef0b34c16def20ecbb8248950070eb5fa33 and later modified those to remove the GPL dependency: 59a7a79c7dc446b723185b346b6fc2f6ffef82dc. And I think we already think about replacing the nvd3 library soon-ish (I saw that we are looking for nvd3 replacement for example) - which in turn will remove the need for slugify. I don't really think there is harm in modifying the files - there is a very slim chance we are going to upgrade to a later version, but even if we do - we should be able to re-apply our own changes anyway. We try to make it in separate commits (https://github.com/apache/airflow/pull/5168) so that we can later cherry-pick those changes in case we want to upgrade to newer version of the library. I think this current change here was a bit unfortunate because the slugify change was not separated out to separate commit, but it's so small change that it will be no problem to re-apply it in case we upgrade. I guess there are also no licensing limitations that would prevent us from doing so - both libs are MIT licence that allows us to modify this code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
