SamWheating commented on a change in pull request #17121:
URL: https://github.com/apache/airflow/pull/17121#discussion_r698150805
##########
File path: tests/dag_processing/test_processor.py
##########
@@ -404,7 +404,7 @@ def test_process_file_should_failure_callback(self):
@conf_vars({("core", "dagbag_import_error_tracebacks"): "False"})
def
test_add_unparseable_file_before_sched_start_creates_import_error(self, tmpdir):
- unparseable_filename = tmpdir / TEMP_DAG_FILENAME
+ unparseable_filename = os.path.join(tmpdir, TEMP_DAG_FILENAME)
Review comment:
These changes are required because the previous `tmpdir / "child_path"`
syntax would return a PathLib object rather than a string, and the
`_process_file` function expects a string.
Providing the wrong type was causing some of the tests to fail due
SQLAlchemy errors.
Using `os.path.join` will explicitly return a string and thus fixes this
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
