kiwy42 edited a comment on pull request #17816:
URL: https://github.com/apache/airflow/pull/17816#issuecomment-908229518
> Not your fault for MSSQL (Something we need to fix) but the static check
is definitely yours to fix ;).
I'm trying but those pre commit static checks I don''t understand, it
compares my file with my previous file but they changed.
I'm a bit puzzled.
Also there's those fail that do not create an explicit error:
```
black....................................................................................Failed
- hook id: black
- files were modified by this hook
reformatted airflow/security/kerberos.py
reformatted tests/security/test_kerberos.py
All done! ✨ 🍰 ✨
2 files reformatted, 2725 files left unchanged.
All done! ✨ 🍰 ✨
244 files left unchanged.
```
and
```
Checks for consistency between config.yml and
default_config.cfg.........................Failed
- hook id: airflow-config-yaml
- files were modified by this hook
Converting
./scripts/ci/pre_commit/../../../airflow/config_templates/config.yml to
./scripts/ci/pre_commit/../../../airflow/config_templates/default_airflow.cfg
Converting
./scripts/ci/pre_commit/../../../airflow/providers/google/config_templates/config.yml
to
./scripts/ci/pre_commit/../../../airflow/providers/google/config_templates/default_config.cfg
```
But what Am I suppose to do when it compares to previous code that in fact
has changed ? :
```
diff --git a/tests/security/test_kerberos.py
b/tests/security/test_kerberos.py
index 2c1c92e..073d1ef 100644
--- a/tests/security/test_kerberos.py
+++ b/tests/security/test_kerberos.py
@@ -43,43 +43,43 @@ class TestKerberos(unittest.TestCase):
"""
assert renew_from_kt(principal=self.args.principal,
keytab=self.args.keytab) is None
- @conf_vars({('kerberos', 'keytab'): KRB5_KTNAME,
('kerberos','include_ip'): ''})
+ @conf_vars({('kerberos', 'keytab'): KRB5_KTNAME, ('kerberos',
'include_ip'): ''})
```
I did those change to solve formatting checks and it creates more error, I
don't understand.
Thank you for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
