potiuk opened a new pull request #17935:
URL: https://github.com/apache/airflow/pull/17935


   When Secrets Backend are instantiated during configuration, not
   all Airlfow packages are yet imported, because they need Secret
   Backends. We have a weird cyclical relation between models,
   configuration and settins which forces us to be extra careful
   around configuration, settings and backends.
   
   In this case top-level import of Connections by the Vault Secret
   Backend triggered cyclic import problem (importing airflow models
   require configuration to be fully loaded and initialized) but then
   it could not be initialized because models needed to be imported
   first.
   
   The fix is to move Connections to be locally imported.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to