ashb commented on a change in pull request #17100:
URL: https://github.com/apache/airflow/pull/17100#discussion_r701000560
##########
File path:
airflow/providers/google/marketing_platform/operators/display_video.py
##########
@@ -362,15 +362,13 @@ class
GoogleDisplayVideo360RunReportOperator(BaseOperator):
template_fields = (
"report_id",
- "params",
"impersonation_chain",
)
def __init__(
self,
*,
report_id: str,
- params: Dict[str, Any],
Review comment:
Same here -- it's a name clash but has a different meaning/use to the
base params.
Maybe both of these should be stored as `self._params`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
