JavierLopezT commented on a change in pull request #17741:
URL: https://github.com/apache/airflow/pull/17741#discussion_r701008583
##########
File path: airflow/providers/snowflake/operators/snowflake.py
##########
@@ -125,3 +126,285 @@ def execute(self, context: Any) -> None:
if self.do_xcom_push:
return execution_info
+
+
+class _SnowflakeDbHookMixin:
Review comment:
DRY philosophy is great. However, my point was that you don't need a
class at all and you can get rid of the class extra layer of abstraction. My
comment is inspired by https://www.youtube.com/watch?v=o9pEzgHorH0
Using the same class too in the SnowflakeOperator has been quite an
improvement, but I think you can still have just a function in the file, and
you can just call it from the operators. Anyway, it's not a big deal and the PR
is already approved, so up to u.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
