jarfgit commented on a change in pull request #17145:
URL: https://github.com/apache/airflow/pull/17145#discussion_r701226027
##########
File path: tests/providers/amazon/aws/hooks/test_s3.py
##########
@@ -124,11 +124,14 @@ def test_list_prefixes(self, s3_bucket):
bucket = hook.get_bucket(s3_bucket)
bucket.put_object(Key='a', Body=b'a')
bucket.put_object(Key='dir/b', Body=b'b')
+ bucket.put_object(Key='dir/sub_dir/c', Body=b'c')
assert [] == hook.list_prefixes(s3_bucket, prefix='non-existent/')
+ assert [] == hook.list_prefixes(s3_bucket)
assert ['dir/'] == hook.list_prefixes(s3_bucket, delimiter='/')
- assert ['a'] == hook.list_keys(s3_bucket, delimiter='/')
- assert ['dir/b'] == hook.list_keys(s3_bucket, prefix='dir/')
+ assert [] == hook.list_prefixes(s3_bucket, prefix='dir/')
+ assert ['dir/sub_dir/'] == hook.list_prefixes(s3_bucket,
delimiter='/', prefix='dir/')
+ assert [] == hook.list_prefixes(s3_bucket, prefix='dir/sub_dir/')
Review comment:
The calls to `list_keys` were in the `test_list_prefixes` unit test. I
didn't immediately see why these calls were there and assumed it might have
been a copy / past error. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
