jedcunningham commented on a change in pull request #17996:
URL: https://github.com/apache/airflow/pull/17996#discussion_r701417592
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
Review comment:
```suggestion
metrics: # or 'scheduler' for Airflow 1
```
This is a cleaner approach to handling the Airflow 2 vs 1 differences I
think? Then we can remove the note above?
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
+ statsd_prefix: airflow
+ extraEnv: |-
+ - name: AIRFLOW__METRICS__STATSD_HOST
+ valueFrom:
+ fieldRef:
+ fieldPath: status.hostIP
+
+-OR-
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ extraEnv: |-
+ - name: AIRFLOW__METRICS__STATSD_ON
+ value: "True"
+ - name: AIRFLOW__METRICS__STATSD_PORT
+ value: ``<port>``
+ - name: AIRFLOW__METRICS__STATSD_PREFIX
+ value: "airflow"
+ - name: AIRFLOW__METRICS__STATSD_HOST
+ valueFrom:
+ fieldRef:
+ fieldPath: status.hostIP
+
Review comment:
```suggestion
```
I think the previous approach is enough, no?
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
Review comment:
```suggestion
statsd_port: 8125
```
I think we should show the default dogstastsd port, thoughts?
##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -184,6 +184,44 @@ To use an external StatsD instance:
statsd_host: ...
statsd_port: ...
+Datadog
+^^^^^^^
+If you are using a Datadog agent in your environment, this will enable Airflow
to export metrics to the Datadog agent.
+NOTE: The below is for version 2.x.x of Airflow. In Airflow 1.x.x the swap
all instances of ``metrics`` for ``scheduler``
+
+.. code-block:: yaml
+
+ statsd:
+ enabled: false
+ config:
+ metrics:
+ statsd_on: true
+ statsd_port: ``<port>``
+ statsd_prefix: airflow
Review comment:
```suggestion
```
We don't need to show the default, do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
