potiuk commented on a change in pull request #17100:
URL: https://github.com/apache/airflow/pull/17100#discussion_r701800858
##########
File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py
##########
@@ -100,15 +99,16 @@ def __init__(
self.facebook_conn_id = facebook_conn_id
self.api_version = api_version
self.fields = fields
- self.params = params
self.gzip = gzip
self.impersonation_chain = impersonation_chain
def execute(self, context: dict):
service = FacebookAdsReportingHook(
facebook_conn_id=self.facebook_conn_id,
api_version=self.api_version
)
- rows = service.bulk_facebook_report(params=self.params,
fields=self.fields)
+ rows = service.bulk_facebook_report(
+ params={k: v.resolve() for k, v in self.params.items()},
fields=self.fields
+ )
Review comment:
We can easily add "additional_requirements' airflow `2.2.0+` for those
two providers, to not complicate things. That will handle 2.2 with "hard" limit
and constraints will take care about the pre-2.2 default installation.
UPDATE: I thought about it and we can also add a functionality in Providers
Manager to check versions of providers from the community and warn if
"unsupported" versions are installed. This will not make "hard" pip limit, but
it will give clear indication that providers should be upgraded in case someone
did not use constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
