mrbaguvix commented on a change in pull request #17883:
URL: https://github.com/apache/airflow/pull/17883#discussion_r702332249
##########
File path: scripts/ci/images/ci_prepare_prod_image_on_ci.sh
##########
@@ -29,10 +29,13 @@ export VERBOSE="true"
# Builds or waits for the PROD image in the CI environment
function build_prod_images_on_ci() {
+ build_images::configure_docker_registry
build_images::prepare_prod_build
if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
- build_images::wait_for_image_tag "${AIRFLOW_PROD_IMAGE}"
":${GITHUB_REGISTRY_PULL_IMAGE_TAG}"
+ local
image_name_with_tag="${AIRFLOW_PROD_IMAGE}:${GITHUB_REGISTRY_PULL_IMAGE_TAG}"
+ push_pull_remove_images::wait_for_image "${image_name_with_tag}"
+ push_pull_remove_images::pull_image "${image_name_with_tag}"
Review comment:
Good stuff!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
