mrbaguvix commented on a change in pull request #17937:
URL: https://github.com/apache/airflow/pull/17937#discussion_r702523532
##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -24,20 +25,29 @@
class FTPToS3Operator(BaseOperator):
"""
- This operator enables the transferring of files from FTP server to S3.
+ This operator enables the transfer of files from FTP server to S3. It can
be used for
+ transfer one or multiple files.
- :param s3_bucket: The targeted s3 bucket in which upload the file to
+ :param ftp_path: The ftp remote path. For one file it is mandatory to
include the file as well.
+ For multiple files, it is the route where the files will be found.
+ :type ftp_path: str
+ :param s3_bucket: The targeted s3 bucket in which upload the file(s) to.
:type s3_bucket: str
- :param s3_key: The targeted s3 key. This is the specified file path for
- uploading the file to S3.
+ :param s3_key: The targeted s3 key. For one file it must include the file
path. For several,
+ it must end with "/".
:type s3_key: str
- :param ftp_path: The ftp remote path, including the file.
- :type ftp_path: str
+ :param ftp_filenames: Only used if you want to move multiple files. You
can pass a list
+ with exact filenames present in the ftp path, or a prefix that all
files must meet.
+ :type ftp_filenames: Union(str, list)
+ :param s3_filenames: Only used if you want to move multiple files and name
them different than
Review comment:
```suggestion
:param s3_filenames: Only used if you want to move multiple files and
name them different from
```
##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -24,20 +25,29 @@
class FTPToS3Operator(BaseOperator):
"""
- This operator enables the transferring of files from FTP server to S3.
+ This operator enables the transfer of files from FTP server to S3. It can
be used for
Review comment:
```suggestion
This operator enables the transfer of files from a FTP server to S3. It
can be used to
```
##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -24,20 +25,29 @@
class FTPToS3Operator(BaseOperator):
"""
- This operator enables the transferring of files from FTP server to S3.
+ This operator enables the transfer of files from FTP server to S3. It can
be used for
+ transfer one or multiple files.
- :param s3_bucket: The targeted s3 bucket in which upload the file to
+ :param ftp_path: The ftp remote path. For one file it is mandatory to
include the file as well.
+ For multiple files, it is the route where the files will be found.
+ :type ftp_path: str
+ :param s3_bucket: The targeted s3 bucket in which upload the file(s) to.
Review comment:
```suggestion
:param s3_bucket: The targeted s3 bucket in which to upload the file(s).
```
##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -24,20 +25,29 @@
class FTPToS3Operator(BaseOperator):
"""
- This operator enables the transferring of files from FTP server to S3.
+ This operator enables the transfer of files from FTP server to S3. It can
be used for
+ transfer one or multiple files.
- :param s3_bucket: The targeted s3 bucket in which upload the file to
+ :param ftp_path: The ftp remote path. For one file it is mandatory to
include the file as well.
+ For multiple files, it is the route where the files will be found.
+ :type ftp_path: str
+ :param s3_bucket: The targeted s3 bucket in which upload the file(s) to.
:type s3_bucket: str
- :param s3_key: The targeted s3 key. This is the specified file path for
- uploading the file to S3.
+ :param s3_key: The targeted s3 key. For one file it must include the file
path. For several,
+ it must end with "/".
:type s3_key: str
- :param ftp_path: The ftp remote path, including the file.
- :type ftp_path: str
+ :param ftp_filenames: Only used if you want to move multiple files. You
can pass a list
+ with exact filenames present in the ftp path, or a prefix that all
files must meet.
+ :type ftp_filenames: Union(str, list)
+ :param s3_filenames: Only used if you want to move multiple files and name
them different than
+ the originals from the ftp. It can be a list of filenames or a files
prefix (that will replace
Review comment:
```suggestion
the originals from the ftp. It can be a list of filenames or file
prefix (that will replace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
