mik-laj commented on a change in pull request #18007:
URL: https://github.com/apache/airflow/pull/18007#discussion_r703311083
##########
File path: tests/providers/neo4j/hooks/test_neo4j.py
##########
@@ -15,51 +15,94 @@
# specific language governing permissions and limitations
# under the License.
#
-import json
import unittest
from unittest import mock
+from parameterized import parameterized
+
from airflow.models import Connection
from airflow.providers.neo4j.hooks.neo4j import Neo4jHook
class TestNeo4jHookConn(unittest.TestCase):
- def setUp(self):
- super().setUp()
- self.neo4j_hook = Neo4jHook()
- self.connection = Connection(
- conn_type='neo4j', login='login', password='password',
host='host', schema='schema'
+ @parameterized.expand(
+ [
+ [dict(), "bolt://host:7687"],
Review comment:
I prefer to avoid initializing an empty dictionary with this syntax
because it is ambiguous. I always have to wonder if this will make an empty
dictionary(``{}==dictt()``) or a set(``{}==set()``).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
