jedcunningham commented on a change in pull request #18068:
URL: https://github.com/apache/airflow/pull/18068#discussion_r703753568
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -161,6 +161,40 @@ If there are any other arguments - they are simply passed
to the "airflow" comma
> docker run -it apache/airflow:2.1.2-python3.6 version
2.1.2
+Signal propagation
+------------------
+
+Airflow uses ``dumb-init`` to run as "init" in the entrypoint. This is in
order to propagate
+signals and reap child processes properly. This means that the process that
you run, does not have
+to install signal handlers to work properly and be killed when the container
is gracefully terminated.
+This is especially useful when yoy have some "graceful" behaviour implemented
such as warm shutdown
Review comment:
```suggestion
This is especially useful when you have some "graceful" behaviour
implemented such as warm shutdown
```
##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -179,6 +179,10 @@ spec:
envFrom:
{{- include "custom_airflow_environment_from" . | default "\n []" |
indent 10 }}
env:
+ # For images before Airflow 2.1.4 setting DUMB_INIT_SESSID to 0
fixes signal propagation
+ # to make Warm Shutdown works properly for Celery Workers
Review comment:
```suggestion
# to make Warm Shutdown work properly for Celery Workers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
