andrewgodwin commented on a change in pull request #18112:
URL: https://github.com/apache/airflow/pull/18112#discussion_r705603271
##########
File path: airflow/exceptions.py
##########
@@ -256,12 +278,21 @@ def __init__(
self.method_name = method_name
self.kwargs = kwargs
self.timeout = timeout
+
# Check timeout type at runtime
if self.timeout is not None and not hasattr(self.timeout,
"total_seconds"):
raise ValueError("Timeout value must be a timedelta")
+ # Check keyword arguments
+ if kwargs:
+ if method_name is None:
+ raise ValueError("Keyword arguments not allowed when method is
not specified")
Review comment:
Recorrecting my thoughts here - it should be fine to have custom kwargs
for `execute`, since it's something you can always override in an operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
