ashb commented on a change in pull request #17100:
URL: https://github.com/apache/airflow/pull/17100#discussion_r706137492
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -878,6 +920,34 @@ def from_dict(cls, serialized_obj: dict) ->
'SerializedDAG':
raise ValueError(f"Unsure how to deserialize version {ver!r}")
return cls.deserialize_dag(serialized_obj['dag'])
+ @classmethod
+ def _serialize_dag_params(cls, dag_params: ParamsDict):
+ """Serialize Params dict for a DAG"""
+ serialized_params = {}
+ for k, v in dag_params.items():
+ # To support backward compatability with some operators, we would
let str params
+ # serialized as well, after converting them into a shallow Param
object.
+ if v.__class__.__name__ == 'str':
Review comment:
```suggestion
if isinstance(v, str):
```
I think you mean Kaxi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
