ashb commented on a change in pull request #18141:
URL: https://github.com/apache/airflow/pull/18141#discussion_r706209185



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -1669,22 +1668,24 @@ def test_scheduler_keeps_scheduling_pool_full(self, 
dag_maker):
         with dag_maker(
             dag_id='test_scheduler_keeps_scheduling_pool_full_d1',
             start_date=DEFAULT_DATE,
-        ) as dag_d1:
+        ):
             BashOperator(
                 task_id='test_scheduler_keeps_scheduling_pool_full_t1',
                 pool='test_scheduler_keeps_scheduling_pool_full_p1',
                 bash_command='echo hi',
             )
+        dag_d1 = dag_maker.dag

Review comment:
       I thought  the dag_maker yielded the dag, so this style of change 
shouldn't be necessary?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to