jhtimmins commented on a change in pull request #18160:
URL: https://github.com/apache/airflow/pull/18160#discussion_r706646302
##########
File path: airflow/www/security.py
##########
@@ -485,12 +485,14 @@ def has_access(self, action_name, resource_name,
user=None) -> bool:
has_access = self._has_access(user, action_name, resource_name)
# FAB built-in view access method. Won't work for AllDag access.
-
if self.is_dag_resource(resource_name):
+ root_dag_resource_name = resource_name.split(".")[0]
Review comment:
@kaxil Yeah you're correct, this is where it should have gone.
Can a valid dag name include a period? If so, you'll need to test for both
the complete version and the root version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
