EtsuNDmA commented on issue #17336:
URL: https://github.com/apache/airflow/issues/17336#issuecomment-917916675


   @eladkal  the way I see it this comment before `json_format` says that json 
specific fields will be used instead of default `log_format`
   ```
   # Instead of the default log formatter, write the log lines as JSON
   json_format = True
   ```
   
   It's confusing that we should change json_fields in elasticsearh section and 
sync it with log_format in logging section. `log_format` furthermore used by 
many other handlers such as `processor_manager` and `processor`. I think that 
`json_fields` should be a subset of `log_format`, but not vice versa. And of 
course such misconfiguration in logging should not leads to RecursionError in 
runtime


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to