kaxil edited a comment on pull request #18228: URL: https://github.com/apache/airflow/pull/18228#issuecomment-920359989
> > > WTH this seems to break `mock_kinesis` somehow? > > This change touches `setup.py` so it upgrades dependencies to latest. > > Seems that Botocore patchlevel was released yesterday and it breaks the test apparently. https://pypi.org/project/botocore/1.21.42/ > > This is our early-warning for new dependencies breaking Airflow at its best. We should take a look at this failed kinesis test and fix it (either fix the test or limit botocore). Only PRs that are updating setup.py (and main) are affected. All other PRs are not, which limits the impact of such dependencies breaking our build. > > This can be reproduced locally by building the image with newer dependencies `./breeze --upgrade-to-newer-dependencies` . > Anyone cares to fix it :) ? Don't think so, we have pinned boto3 to <1.18 (https://github.com/apache/airflow/blob/29d700dd3de7ede6b5c426f397418deb3cc7a916/setup.py#L186) Which pins botocore version (`botocore>=1.20.112,<1.21.0`): https://github.com/boto/boto3/blob/577672298d619e59b0806aad0606d2974803c561/setup.py#L17 And from CI (https://github.com/apache/airflow/pull/18228/checks?check_run_id=3606187405#step:8:1157): ``` Collecting botocore<1.21.0,>=1.20.112 Downloading botocore-1.20.112-py2.py3-none-any.whl (7.7 MB) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
