ignaski commented on a change in pull request #18287:
URL: https://github.com/apache/airflow/pull/18287#discussion_r709987699
##########
File path: airflow/providers/microsoft/azure/hooks/wasb.py
##########
@@ -172,7 +172,7 @@ def _get_blob_client(self, container_name: str, blob_name:
str) -> BlobClient:
:param blob_name: The name of the blob. This needs not be existing
:type blob_name: str
"""
- container_client = self.create_container(container_name)
+ container_client = self._get_container_client(container_name)
Review comment:
`_get_blob_client` is used in 3 methods: `check_for_blob`, `download`
and `upload`. Only the `upload` is `write` type of operation. In this case,
would it make sense to call `create_container` in the `upload` before asking
for blob client? This way the method `_get_blob_client` could only be
responsible for returning the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
