ephraimbuddy commented on a change in pull request #18310:
URL: https://github.com/apache/airflow/pull/18310#discussion_r711363194



##########
File path: airflow/jobs/local_task_job.py
##########
@@ -226,6 +226,18 @@ def heartbeat_callback(self, session=None):
     @Sentry.enrich_errors
     def _run_mini_scheduler_on_child_tasks(self, session=None) -> None:
         try:
+
+            if (
+                self.task_instance.task.wait_for_downstream
+                and self.task_instance.get_previous_ti()
+                and not self.task_instance.are_dependents_done()
+            ):

Review comment:
       This logic is needed here even though the 
task_instance_scheduling_decisions is also performing this logic. 
   
   With mini scheduler disabled, the scheduler works fine with 
wait_for_downstream set. 
   
   Probably a case of race condition?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to