potiuk opened a new pull request #18346:
URL: https://github.com/apache/airflow/pull/18346
Sentry by default monkey-patches standard library POpen function
to capture and pass current process' environment to subprocess
with `SUBPROCESS_` prefix. This break SubprocessHook tests
when sentry tests are run before SubprocessHook tests, and also
it modifies SubprocessHook behaviour (and promise) in production
environment as well.
This PR:
* adds documentation to both sentry documentation and the
SubprocessHook documentation explaining the interaction between
the two
* Adds documentation explaining how to disable this default
Sentry behaviour
* disables default integrations in the Sentry tests to avoid
side-effects
Fixes: #18268
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
